Automatic inverse link #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
palday
commented
Aug 19, 2023
palday
commented
- adds a way to create extensions for automatic inverse link determination
- defines such extensions for GLM and MixedModels
- this also allows using analytic deritvatives instead of AD for the difference method
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
===========================================
- Coverage 100.00% 99.42% -0.58%
===========================================
Files 4 6 +2
Lines 154 174 +20
===========================================
+ Hits 154 173 +19
- Misses 0 1 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kleinschmidt
approved these changes
Aug 21, 2023
ararslan
reviewed
Aug 21, 2023
Co-authored-by: Alex Arslan <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ararslan
reviewed
Aug 21, 2023
|
|
||
| [extensions] | ||
| EffectsGLMExt = "GLM" | ||
| EffectsMixedModelsExt = ["GLM", "MixedModels"] |
There was a problem hiding this comment.
IIUC this will only be loaded if both MixedModels and GLM are loaded. I don't think that restriction is necessary since MixedModels depends on GLM.
There was a problem hiding this comment.
🤷 I wanted to be explicit
Comment on lines
+73
to
+75
| @test all(pred.prediction .≈ eff.vol) | ||
| @test all(isapprox.(pred.lower, eff.lower; atol=0.001)) | ||
| @test all(isapprox.(pred.upper, eff.upper; atol=0.001)) |
There was a problem hiding this comment.
Suggested change
| @test all(pred.prediction .≈ eff.vol) | |
| @test all(isapprox.(pred.lower, eff.lower; atol=0.001)) | |
| @test all(isapprox.(pred.upper, eff.upper; atol=0.001)) | |
| @test pred.prediction ≈ eff.vol | |
| @test pred.lower ≈ eff.lower atol=0.001 | |
| @test pred.upper ≈ eff.upper atol=0.001 |
Any reason not to test the approximate equality of the arrays directly?
There was a problem hiding this comment.
because we want element-wise approximate equality, which is a stronger condition (the approximate equality of vectors is based on the norm of the difference vector)
Comment on lines
+83
to
+85
| @test all(eff_trans.vol .≈ eff.vol) | ||
| @test all(isapprox.(eff_trans.lower, eff.lower; atol=0.001)) | ||
| @test all(isapprox.(eff_trans.upper, eff.upper; atol=0.001)) |
There was a problem hiding this comment.
Suggested change
| @test all(eff_trans.vol .≈ eff.vol) | |
| @test all(isapprox.(eff_trans.lower, eff.lower; atol=0.001)) | |
| @test all(isapprox.(eff_trans.upper, eff.upper; atol=0.001)) | |
| @test eff_trans.vol ≈ eff.vol | |
| @test eff_trans.lower ≈ eff.lower atol=0.001 | |
| @test eff_trans.upper ≈ eff.upper atol=0.001 |
Same question as above
Co-authored-by: Alex Arslan <[email protected]>
Co-authored-by: Alex Arslan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.